Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade SDK V212E #9

Merged
merged 3 commits into from
Oct 9, 2024
Merged

feat: Upgrade SDK V212E #9

merged 3 commits into from
Oct 9, 2024

Conversation

vicary
Copy link
Owner

@vicary vicary commented Aug 28, 2024

Exposing new properties and methods added in the new versions.

  1. printerCheckEx (iOS)
  2. openDrawerEx (iOS)
  3. PageModeArea property
  4. PageModePrinteArea property
  5. PageModePrintDirection property
  6. PageModeHorizontalPosition property
  7. PageModeVerticalPosition property
  8. RecLineSpacing property
  9. MapMode property

Checklist:

  1. Upgrade RN to 0.75
    1. Reinitialize example app in Expo because upgrading RN is a pain
  2. Test Android builds
    1. oldarch
    2. newarch
  3. Test iOS builds
    1. oldarch
    2. newarch

Note for future me

The error ... RCTEvents.receiveEvent() of undefined. Module has not been registered as a callable ... is specifically triggered by expo-router and in turn react-native-screens over the bridgeless mode enforced by expo when New Architecture is enabled.

This only happens when index.tsx is used at app/ root in iOS.

Exposing new properties and methods added in the new versions.
1. printerCheckEx (iOS)
2. openDrawerEx (iOS)
3. PageModeArea property
4. PageModePrinteArea property
5. PageModePrintDirection property
6. PageModeHorizontalPosition property
7. PageModeVerticalPosition property
8. RecLineSpacing property
9. MapMode property
@vicary vicary force-pushed the feat/sdk-v212e branch 8 times, most recently from 0dc3386 to 88818ba Compare September 4, 2024 07:37
@HatalDev
Copy link

HatalDev commented Oct 8, 2024

@vicary hi, i run my app after more than a month and the usb connection isn't working anymore, even tough my code haven't changed, i tried to run your example app on my other computer(the one i did the test for the project) and it also not working, however when i download this branch with the updated SDK it's working flawless, do you have any idea why it's happening ? and when you will release this sdk update to the main branch?

@vicary
Copy link
Owner Author

vicary commented Oct 8, 2024

@HatalDev It sounds like some kind of minor version upgrade is breaking it, stale node_modules, or build caches.

On the other hand, the only thing stopping this branch is the way that expo-router treats index.ts is breaking this version of example app. If you are sure this branch is working for you, we can publish this branch very soon.

@HatalDev
Copy link

HatalDev commented Oct 9, 2024

@vicary i've tried your solution with the node_modules and completly clean the build caches and still not working with the "Failed connection to the printer", only the new branch is working for me now.
When can you release it?

@vicary vicary merged commit e1ce7c3 into main Oct 9, 2024
3 checks passed
@vicary vicary deleted the feat/sdk-v212e branch October 9, 2024 07:06
@vicary
Copy link
Owner Author

vicary commented Oct 9, 2024

@HatalDev It's released, please give 0.4.0 a test. I'll add the caveat to README later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants